lundi 8 août 2016

Am I doing correct with page object model in Selenium?

I'm trying to automate prestashop test cases by Selenium WebDriver. Am I doing it correct, especially with page object model?

This is my HomePagePOM class:

package pageObjects;
import org.openqa.selenium.By;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.WebElement;
import org.openqa.selenium.Alert;

public class HomePagePOM {
    private static WebElement element = null;
    private static WebDriver driver = null;
    public static String correctLogin = "aaaa";

    public static void enterPage(WebDriver driver) {
        driver.get("http://website.com");
    }

    public static WebElement homeLogo(WebDriver driver) {
        element = driver.findElement(By.id("header_logo"));
        return element;
    }

    public static WebElement searchBar(WebDriver driver) {
        element = driver.findElement(By.id("search_query_top"));
        return element;
    }

    public static WebElement searchBarButton(WebDriver driver) {
        element = driver.findElement(By.name("submit_search"));
        return element;
    }

    public static WebElement contactUs(WebDriver driver) {
        element = driver.findElement(By.id("contact-link"));
        return element;
    }

    public static WebElement signIn(WebDriver driver) {
        element = driver.findElement(By.className("header_user_info"));
        return element;
    }

}

This is my LoginPagePOM class:

package pageObjects;

import org.openqa.selenium.By;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.WebElement;

public class LoginPagePOM {
    private static WebElement element = null;
    private static WebDriver driver = null;
    public static String correctLogin = "client";
    public static String incorrectLogin = "client_incorrect";
    public static String correctPassword = "pass_correct";
    public static String incorrectPassword = "pass_incorrect";

    public static WebElement createAccountField(WebDriver driver) {
        element = driver.findElement(By.id("email_create"));
        return element;
    }
    public static WebElement registeredEmailField(WebDriver driver) {
        element = driver.findElement(By.id("email"));
        return element;
    }
    public static WebElement registeredPasswordField(WebDriver driver) {
        element = driver.findElement(By.id("passwd"));
        return element;
    }
    public static WebElement registeredSubmitButton(WebDriver driver) {
        element = driver.findElement(By.id("SubmitLogin"));
        return element;
    }
    public static WebElement createAccountButton(WebDriver driver) {
        element = driver.findElement(By.id("SubmitCreate"));
        return element;
    }
}

And this is my LoginPageCorrectLogin class, which execute one sigle test case - correct login to the prestashop website:

package testCases;
import pageObjects.HomePagePOM;
import pageObjects.LoginPagePOM;
import org.openqa.selenium.By;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.WebElement;
import org.openqa.selenium.firefox.FirefoxDriver;

public class LoginPageCorrectLogin {
    public static WebDriver driver = null;
    public static WebElement element = null;
    public static void main(String[] args) {
        driver = new FirefoxDriver();

        HomePagePOM.enterPage(driver); //Enter home site
        HomePagePOM.signIn(driver).click(); //Find Sign In option and click
        LoginPagePOM.registeredEmailField(driver).sendKeys(LoginPagePOM.correctLogin); // Input correct login to field
        LoginPagePOM.registeredPasswordField(driver).sendKeys(LoginPagePOM.correctPassword); //Input correct password to field
        LoginPagePOM.registeredSubmitButton(driver).click(); // Click on submit button
    }

}

I'm begginer at Selenium, but I want to using best practises. Is it correct? For this example I will create other classes like LoginPageCorrectPassword, LoginPageIncorrectLogin, LoginPageIncorrectPassword. Any advices about page model object will be very helpful.

Aucun commentaire:

Enregistrer un commentaire